[PATCH] D144608: [InstCombine] Add transforms for `(icmp (xor X, Y), X)`

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 2 23:50:36 PST 2023


goldstein.w.n added a comment.

In D144608#4158566 <https://reviews.llvm.org/D144608#4158566>, @spatel wrote:

> This is adding a lot of code to a function that's already too big. A helper function will make it easier to read.
>
> This seems like 2 or 3 independent patches? I just looked at the first group of 4 Alive proofs, and those seem fine.

Sorry just saw this, will do so, likewise for the `or` patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144608/new/

https://reviews.llvm.org/D144608



More information about the llvm-commits mailing list