[PATCH] D144608: [InstCombine] Add transforms for `(icmp (xor X, Y), X)`

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

This is adding a lot of code to a function that's already too big. A helper function will make it easier to read.

This seems like 2 or 3 independent patches? I just looked at the first group of 4 Alive proofs, and those seem fine.



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:4409
+      CmpInst::Predicate PredOut = Pred;
+      switch (Pred) {
+      case ICmpInst::ICMP_ULE:
----------------
Use isNonStrictPredicate() / getStrictPredicate() ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144608/new/

https://reviews.llvm.org/D144608