[PATCH] D143708: [RISCV] Support emulated TLS

Thu Mar 2 17:05:37 PST 2023

craig.topper added inline comments.

================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4655
+
   assert(N->getOffset() == 0 && "unexpected offset in global node");

----------------
vit9696 wrote:
> jrtc27 wrote:
> > Should this assert apply? Given it's true of ELF TLS I'd expect it of emulated TLS too?
> Is this offset within the TLS space? If so, I am not sure it cannot be 0 for emutls.
> 
> I do not have enough knowledge of the codebase to make this decision, and I am reluctant to make a blind change. Can apply if you insist & explain why it should be safe.
I think it should always be 0 because `RISCVTargetLowering::isOffsetFoldingLegal` returns false.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143708/new/

https://reviews.llvm.org/D143708