[PATCH] D143708: [RISCV] Support emulated TLS
Vitaly Cheptsov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 2 16:56:49 PST 2023
vit9696 added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4655
+
assert(N->getOffset() == 0 && "unexpected offset in global node");
----------------
jrtc27 wrote:
> Should this assert apply? Given it's true of ELF TLS I'd expect it of emulated TLS too?
Is this offset within the TLS space? If so, I am not sure it cannot be 0 for emutls.
I do not have enough knowledge of the codebase to make this decision, and I am reluctant to make a blind change. Can apply if you insist & explain why it should be safe.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143708/new/
https://reviews.llvm.org/D143708
More information about the llvm-commits
mailing list