[PATCH] D145170: [AMDGPU] Vectorize misaligned global loads & stores

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 2 15:42:58 PST 2023


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.h:431
+
+inline bool isGlobalAddrSpace(unsigned AS) {
+  return AS == AMDGPUAS::GLOBAL_ADDRESS || AS == AMDGPUAS::CONSTANT_ADDRESS ||
----------------
I do not like the name here. It suggests it is global address space only.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145170/new/

https://reviews.llvm.org/D145170



More information about the llvm-commits mailing list