[PATCH] D144189: [AIX][CodeGen] Storage Locations for Constant Pointers

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-roptr.ll:5
+; RUN: llc -mtriple powerpc-ibm-aix-xcoff -mroptr -filetype=obj -o %t.o < %s
+; RUN: llvm-objdump -t %t.o | FileCheck %s --check-prefix=OBJ
+
----------------
Please add `--symbol-description` (and observe that the storage mapping class is displayed as well).


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-roptr.ll:22
+;OBJ:      000001a8 l       .text	00000004 _ZL1p
+;OBJ:      000001ac g       .text	00000004 u
+;OBJ:      00000294 g     O .data	00000008 dd
----------------
Would `OBJ-DAG` allow the test to be written with the check lines in the order of the IR definitions?


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-roptr.ll:29-31
+;OBJ:      0000030c l     O .data	00000004 .q
+;OBJ-NEXT: 00000310 l     O .data	00000004 q
+;OBJ-NEXT: 00000000 g     O .tdata	00000004 q
----------------
Updating with the `--symbol-description` output would really help here.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-roptr.ll:38-41
+;CHECK:         .csect dd[RW],2
+;CHECK-NEXT:    .globl	dd[RW]
+;CHECK-NEXT:    .align	2
+;CHECK-NEXT:    .space	8
----------------
`dd` is not the interesting at the IR level.
Also, all of the C++ implementation artifacts below are unchecked anyway.


================
Comment at: llvm/test/CodeGen/PowerPC/aix64-xcoff-roptr.ll:1
+; RUN: llc -mtriple powerpc64-ibm-aix-xcoff -mroptr < %s | FileCheck %s
+; RUN: llc -mtriple powerpc64-ibm-aix-xcoff -mroptr -filetype=obj -o %t.o < %s
----------------
Same comments as for the 32-bit case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144189/new/

https://reviews.llvm.org/D144189