[PATCH] D144189: [AIX][CodeGen] Storage Locations for Constant Pointers

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/tools/llc/llc.cpp:502
+      if (!TheTriple.isOSAIX())
+        reportError("-mroptr option is only supported on AIX.", InputFilename);
+
----------------
Other calls to `reportError` do not appear to use periods at the end of the message.


================
Comment at: llvm/tools/llc/llc.cpp:506-509
+      // be done for the read only pointers. Using read only pointers
+      // may cause RW variables in the same csection to be RO.
+      // Therefore separate data sections for globals are rquired
+      // in the presense of ReadOnlyPointers.
----------------
Suggestion: Adjusted/expanded code comment


================
Comment at: llvm/tools/llc/llc.cpp:511
+      if (!Options.DataSections)
+        reportError("-mroptr option must be used with -data-sections.",
+                    InputFilename);
----------------
Same comment as above regarding ending full-stop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144189/new/

https://reviews.llvm.org/D144189