[PATCH] D145070: [clang][RISCV][test] Add test coverage for _Float16 ABI lowering

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 1 07:27:12 PST 2023


asb created this revision.
asb added reviewers: kito-cheng, craig.topper, reames, jrtc27.
Herald added subscribers: luke, wingo, pmatos, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, shiva0217, niosHD, sabuasal, simoncook, johnrusso, rbar, arichardson.
Herald added a project: All.
asb requested review of this revision.
Herald added subscribers: pcwang-thead, eopXD, MaskRay.

I believe that by the psABI, any test case where a FPR would be used for a float, it should also be used if you replaced that float with a _Float16. This doesn't hold true for the special cases in the FP calling convention involving structs. This patch doesn't attempt to fix that, simply to add coverage.

I've also directly committed some other patches that expand our coverage for _Float16 behaviour.


https://reviews.llvm.org/D145070

Files:
  clang/test/CodeGen/RISCV/riscv32-abi.c
  clang/test/CodeGen/RISCV/riscv64-abi.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145070.501504.patch
Type: text/x-patch
Size: 36220 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230301/d9de1f7b/attachment-0001.bin>


More information about the llvm-commits mailing list