[PATCH] D140369: [PowerPC] update PPCTTIImpl::supportsTailCallFor() check conditions
Ting Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 28 17:35:16 PST 2023
tingwang added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5672
+ CalleeGV, CalleeCC, CallerCC, CB, CalleeFunc->isVarArg(), Outs, Ins,
+ false /*IsByValArg*/, CallerFunc, false /*isCalleeExternalSymbol*/);
+}
----------------
shchenz wrote:
> we may need a NFC patch to remove the `IsByValArg` for `isEligibleForTCO` as all callers pass `false` to it, we should be able to check the byval parameter inside `isEligibleForTCO`.
Sure, will do. Thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140369/new/
https://reviews.llvm.org/D140369
More information about the llvm-commits
mailing list