[PATCH] D144846: [IR][Legalization] Promote illegal deinterleave and interleave vectors

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:5311-5313
+  unsigned OtherResNo = 1 - ResNo;
+  SetPromotedInteger(SDValue(N, ResNo), Res.getValue(ResNo));
+  SetPromotedInteger(SDValue(N, OtherResNo), Res.getValue(OtherResNo));
----------------
Can this be simplified to:
```
SetPromotedInteger(SDValue(N, 0), Res.getValue(0));
SetPromotedInteger(SDValue(N, 1), Res.getValue(1));
```


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:5326-5328
+  unsigned OtherResNo = 1 - ResNo;
+  SetPromotedInteger(SDValue(N, ResNo), Res.getValue(ResNo));
+  SetPromotedInteger(SDValue(N, OtherResNo), Res.getValue(OtherResNo));
----------------
As above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144846/new/

https://reviews.llvm.org/D144846