[PATCH] D144776: [X86][MC] Early bail out in emitREXPrefix, NFCI

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 25 04:30:20 PST 2023


pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp:1207
+  default:
+    llvm_unreachable("Unexpected form in emitREXPrefix!");
+  case X86II::RawFrmMemOffs:
----------------
How about move the check here:
```
if (HasRegOp)
  llvm_unreachable("Unexpected form in emitREXPrefix!");
```
Then you don't need the lambda expression.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144776/new/

https://reviews.llvm.org/D144776



More information about the llvm-commits mailing list