[PATCH] D144776: [X86][MC] Early bail out in emitREXPrefix, NFCI

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 25 04:26:55 PST 2023


skan added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp:1193
   }
+  if (!HasRegOp) {
+    PrefixKind Kind = Prefix.determineOptimalKind();
----------------
pengfei wrote:
> You intend to `!NumOps || !HasRegOp`?
`!NumOps || !HasRegOp` is same as `!HasRegOp` b/c `!NumOps` implies `!HasRegOp`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144776/new/

https://reviews.llvm.org/D144776



More information about the llvm-commits mailing list