[PATCH] D144673: Add tests to reproduce pointer/index width confusion crashes

[Krzysztof Drewniak via Phabricator via llvm-commits]

krzysz00 added a subscriber: arichardson.
krzysz00 added a comment.

Re filing my own reverts: I agree, and I know that it's reasonable to revert my own breaking changes so as to not break other people.

In this specific circumstance, the first I learned of the breaking was around my 1 AM when I saw y'all's comments about how the tests were failing with assertions off, and I wasn't in a position where I could do the revert at that time. So, rather than having everyone wait on me getting in to work the next day, I commented that it'd be fine to revert this.

On the subject of precommit tests, in the underlying diff, @arichardson recommend precommitting `not --crash` tests, so I went for that without realizing the impact on assertions-off builds.

Apologies for all the trouble.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144673/new/

https://reviews.llvm.org/D144673