[PATCH] D144673: Add tests to reproduce pointer/index width confusion crashes
Dmitri Gribenko via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 24 04:29:05 PST 2023
gribozavr2 added a comment.
Sorry everyone, I reverted this change in https://github.com/llvm/llvm-project/commit/736e788c58f946f236bd5c80e17eb4a5448056d5.
> Will fix logical tomorrow (feel free to revert until then)
I'd like to ask you to revert yourself immediately next time you're notified that a change broke builds. See the policy at https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy
> When should you revert your own change?
>
> Any time you learn of a serious problem with a change, you should revert it. We strongly encourage “revert to green” as opposed to “fixing forward”.
There are many people in the community who depend on the health of the codebase. If everyone was leaving the code broken until they have time to commit a proper fix, the builds would be permanently broken.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144673/new/
https://reviews.llvm.org/D144673
More information about the llvm-commits
mailing list