[PATCH] D144618: [ConstantFold][InstSimplify] Pre-commit tests for D144445 (NFC)

[Kohei Asano via Phabricator via llvm-commits]

khei4 abandoned this revision.
khei4 added a comment.

missed to tie with the actual commit https://reviews.llvm.org/rG0eb45cd081e4ad8c496aa8358082ef2644c6a50f. abandon this revision.



================
Comment at: llvm/test/Transforms/InstSimplify/load-patterned-aggregates.ll:29
+
+define i32 @load_gep_const_patterned_array(i64 %idx) {
+; CHECK-LABEL: @load_gep_const_patterned_array(
----------------
StephenFan wrote:
> I think this case can also be folded since every i32 values in constarray are same. Is there a TODO missing? 
> And BTW, we can also fold it if replace `[4 x i32]` with `[4 x i16]`. See https://alive2.llvm.org/ce/z/xt2c2z .
> I think this case can also be folded since every i32 values in constarray are same. Is there a TODO missing?

Thank you! Right. But sorry, I failed to tie the actual commit with this revision, already committed by https://reviews.llvm.org/rG0eb45cd081e4ad8c496aa8358082ef2644c6a50f so I'll implement in https://reviews.llvm.org/D144445.

> And BTW, we can also fold it if replace [4 x i32] with [4 x i16]. See https://alive2.llvm.org/ce/z/xt2c2z .

That's also right. Thank you for comments!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144618/new/

https://reviews.llvm.org/D144618