[PATCH] D144618: [ConstantFold][InstSimplify] Pre-commit tests for D144445 (NFC)

luxufan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 23 06:12:29 PST 2023


StephenFan added inline comments.


================
Comment at: llvm/test/Transforms/InstSimplify/load-patterned-aggregates.ll:29
+
+define i32 @load_gep_const_patterned_array(i64 %idx) {
+; CHECK-LABEL: @load_gep_const_patterned_array(
----------------
I think this case can also be folded since every i32 values in constarray are same. Is there a TODO missing? 
And BTW, we can also fold it if replace `[4 x i32]` with `[4 x i16]`. See https://alive2.llvm.org/ce/z/xt2c2z .


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144618/new/

https://reviews.llvm.org/D144618



More information about the llvm-commits mailing list