[PATCH] D144162: [AMDGPU] Replace LegacyDA with Uniformity Analysis in AnnotateUniformValues

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds added a comment.

In D144162#4141978 <https://reviews.llvm.org/D144162#4141978>, @gandhi21299 wrote:

> In D144162#4140550 <https://reviews.llvm.org/D144162#4140550>, @sameerds wrote:
>
>> I agree with @gandhi21299 ... it's best to work through the passes one at a time. But maybe we should not enable each change as it happens. We could put the changes behind a command-line option to switch between DA and UA. One single option that switches whatever passes have been updated, until all passes are updated and we are ready to flip the switch permanently.
>
> Do you mean a single option that determines the analysis to use and all transformations use analysis depending on the option value? Something like `--enable-uniformity-analysis=1`?

Not exactly like that. We can make the UA a wrapper over the DA, and update the passes to use only the UA. Depending on the commandline, the UA will actually compute its own results, or simply hand off to a DA stored internally. This is how the legacy DA and the DA are currently arranged.

Once we are ready to shift to UA for good, we can eliminate all this. And we should.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144162/new/

https://reviews.llvm.org/D144162