[PATCH] D144162: [AMDGPU] Replace LegacyDA with Uniformity Analysis in AnnotateUniformValues

Ruiling, Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 21 17:24:04 PST 2023


ruiling added a comment.

In D144162#4140550 <https://reviews.llvm.org/D144162#4140550>, @sameerds wrote:

> I agree with @gandhi21299 ... it's best to work through the passes one at a time. But maybe we should not enable each change as it happens. We could put the changes behind a command-line option to switch between DA and UA. One single option that switches whatever passes have been updated, until all passes are updated and we are ready to flip the switch permanently.

Another possible way may be do the replacement one pass by one pass, but we only submit all the changes until all the passes have switched to uniform analysis.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144162/new/

https://reviews.llvm.org/D144162



More information about the llvm-commits mailing list