[PATCH] D142428: [InstCombine] Add tests that patterns for knownbits of and/or/xor apply in `SimplifyDemandedUseBits`; NFC

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added a comment.

In D142428#4145782 <https://reviews.llvm.org/D142428#4145782>, @nikic wrote:

> Hm, do we actually need these tests? It looks like the ValueTracking/knownbits-and-or-xor-lowbit.ll tests already demonstrate that the low bit patterns fold via demanded bits, and ValueTracking/knownbits-bmi-pattern.ll that the bmi patterns do as well, which covers all the relevant special cases, right?

I think for the most part they are redundant (given the other files). LMK if you want me to drop (added mostly b.c policy is tests come with any patch).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142428/new/

https://reviews.llvm.org/D142428