[PATCH] D142428: [InstCombine] Add tests that patterns for knownbits of and/or/xor apply in `SimplifyDemandedUseBits`; NFC

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 22 14:13:22 PST 2023


nikic added a comment.

Hm, do we actually need these tests? It looks like the ValueTracking/knownbits-and-or-xor-lowbit.ll tests already demonstrate that the low bit patterns fold via demanded bits, and ValueTracking/knownbits-bmi-pattern.ll that the bmi patterns do as well, which covers all the relevant special cases, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142428/new/

https://reviews.llvm.org/D142428



More information about the llvm-commits mailing list