[PATCH] D144092: [RISCV] Lower interleave and deinterleave intrinsics

[Luke Lau via Phabricator via llvm-commits]

luke added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:6703
+
+    SDValue VLMAX = DAG.getNode(
+        ISD::VSCALE, DL, XLenVT,
----------------
reames wrote:
> See newly added computeVLMax.
It looks like `computeVLMAX` computes the maximum VLMAX statically, not the actual VLMAX on the current hardware.
Although there's a bunch of other places where VLMAX is computed.
Maybe we can rename `computeVLMAX` to `computeMaxVLMAX`, and then add a helper function `getVLMAX`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144092/new/

https://reviews.llvm.org/D144092