[PATCH] D144092: [RISCV] Lower interleave and deinterleave intrinsics

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 21 10:08:09 PST 2023


reames added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:6635
+
+  MVT IdxVT = WideVT.changeVectorElementTypeToInteger();
+  // Create a vector of even indices {0, 2, 4, ...}
----------------
reames wrote:
> The index type here doesn't look right.  Say we have two vectors of i8.  On a VLEN>2048 machine, we need the index type to be larger than i8.  
Realized the case I raised is unreachable until the fast path above is removed (as I suggested).  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144092/new/

https://reviews.llvm.org/D144092



More information about the llvm-commits mailing list