[PATCH] D143646: [RISCV] Return false from shouldFormOverflowOp

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 20 16:54:49 PST 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:8931
+    SDValue NewADD = DAG.getNode(ISD::ADD, DL, OpVT, N00, N01);
+    DAG.ReplaceAllUsesWith(N0, NewADD);
+  }
----------------
This replaces N0, but the variable N0 still escapes into the following code pointing at the original ADD.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143646/new/

https://reviews.llvm.org/D143646



More information about the llvm-commits mailing list