[PATCH] D139000: [AMDGPU] Remove function with incompatible features

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

Not my favorite but I guess we can do this for now



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:1079
     addPass(createFlattenCFGPass());
+
   return false;
----------------
Extra whitespace change


================
Comment at: llvm/test/CodeGen/AMDGPU/remove-incompatible-functions.ll:845
+; GFX11:       ; %bb.0:
+; GFX11-NEXT:    s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
+; GFX11-NEXT:    s_waitcnt_vscnt null, 0x0
----------------
Pierre-vh wrote:
> arsenm wrote:
> > Also should include IR check lines
> Now that I think about it it's probably better to just check the IR and nothing else. I initially checked the asm because I used unreachable and wanted to check that it was correctly emitted but now it doesn't really matter.
There'd be some value in testing codegen if these also were testing the failing intrinsics in the bodies


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139000/new/

https://reviews.llvm.org/D139000