[PATCH] D139000: [AMDGPU] Remove function with incompatible features

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURemoveIncompatibleFunctions.cpp:56
+  bool runOnModule(Module &M) override {
+    if (skipModule(M))
+      return false;
----------------
arsenm wrote:
> I didn't know there was a skipModule, is this the same as skipFunction in that we shouldn't be doing it for required passes?
It's similar I think so I removed it


================
Comment at: llvm/test/CodeGen/AMDGPU/remove-incompatible-functions.ll:845
+; GFX11:       ; %bb.0:
+; GFX11-NEXT:    s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
+; GFX11-NEXT:    s_waitcnt_vscnt null, 0x0
----------------
arsenm wrote:
> Also should include IR check lines
Now that I think about it it's probably better to just check the IR and nothing else. I initially checked the asm because I used unreachable and wanted to check that it was correctly emitted but now it doesn't really matter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139000/new/

https://reviews.llvm.org/D139000