[PATCH] D144339: [TextAPI] Implement TBDv5 Writer

[Cyndy Ishida via Phabricator via llvm-commits]

cishida added inline comments.


================
Comment at: llvm/include/llvm/TextAPI/InterfaceFile.h:399
     std::function<bool(const Symbol *)> fn = [](const Symbol *Symbol) {
-      return !Symbol->isUndefined();
+      return !Symbol->isUndefined() && !Symbol->isReexported();
+    };
----------------
ributzka wrote:
> Re-exported symbols are also exported symbols. Won't this affect the existing users of this function (e.g. TextStub serializer)?
I don't think so. All the writers also emit a reexport section so those symbols still get printed out. In an installAPI case we wouldn't know whether an export is a reexport so those symbols just look like exports (unless reexported and in that case they just get deleted so there's nothing to print).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144339/new/

https://reviews.llvm.org/D144339