[PATCH] D144339: [TextAPI] Implement TBDv5 Writer

Juergen Ributzka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 20 09:05:10 PST 2023


ributzka added inline comments.


================
Comment at: llvm/include/llvm/TextAPI/InterfaceFile.h:399
     std::function<bool(const Symbol *)> fn = [](const Symbol *Symbol) {
-      return !Symbol->isUndefined();
+      return !Symbol->isUndefined() && !Symbol->isReexported();
+    };
----------------
Re-exported symbols are also exported symbols. Won't this affect the existing users of this function (e.g. TextStub serializer)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144339/new/

https://reviews.llvm.org/D144339



More information about the llvm-commits mailing list