[PATCH] D144399: [AArch64] Add tests for saba (NFC)

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 20 09:05:49 PST 2023


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Yeah they sounds OK to add to me. The tests LGTM, whether you want to update the triple or not.



================
Comment at: llvm/test/CodeGen/AArch64/neon-saba.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s | FileCheck %s
+
----------------
I think most tests use -mtriple aarch64-unknown-linux-gnu -mattr=+neon.

But I think +neon is default, so shouldn't be needed. For the sve tests it will be needed though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144399/new/

https://reviews.llvm.org/D144399



More information about the llvm-commits mailing list