[PATCH] D144399: [AArch64] Add tests for saba (NFC)

Ricardo Jesus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 20 08:18:08 PST 2023


rjj added a comment.

In D144399#4139145 <https://reviews.llvm.org/D144399#4139145>, @SjoerdMeijer wrote:

> About:
>
>   llvm/test/CodeGen/AArch64/neon-saba.ll
>
> @dmgreen  wrote in the other patch:
>
>> Nothing in this file seems to change. We already have abd tests for the nsw cases in neon-abd.ll.
>
> These tests are for sabd, and so these tests are good additions. Is that it?

These tests are for saba. It is true they don't change (i.e. the current code generated is good), I just thought to include them for completeness. But I can drop them if you think they are unnecessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144399/new/

https://reviews.llvm.org/D144399



More information about the llvm-commits mailing list