[PATCH] D144375: [SystemZ, SLP] Enable FP horizontal reductions and fix SLP cost computation.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 20 05:43:43 PST 2023


ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:8470-8472
+    for (unsigned I = 0; I < VL.size(); ++I)
+      if (isa<LoadInst>(VL[I]))
+        ++EltLoads;
----------------
ABataev wrote:
> Better to calculate scalarization overhead for the loadinst elements and subtract from the gather cost.
Or better to include this check to the getGatherCost function


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144375/new/

https://reviews.llvm.org/D144375



More information about the llvm-commits mailing list