[PATCH] D144375: [SystemZ, SLP] Enable FP horizontal reductions and fix SLP cost computation.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 20 05:17:59 PST 2023


ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:8470-8472
+    for (unsigned I = 0; I < VL.size(); ++I)
+      if (isa<LoadInst>(VL[I]))
+        ++EltLoads;
----------------
Better to calculate scalarization overhead for the loadinst elements and subtract from the gather cost.


================
Comment at: llvm/test/Analysis/CostModel/SystemZ/vector-reductions-fp.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_analyze_test_checks.py
+; RUN: opt -passes='print<cost-model>' -disable-output -mtriple=s390x-unknown-linux \
----------------
Better to precomit new tests to better see the changes/differences in a separate patch


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144375/new/

https://reviews.llvm.org/D144375



More information about the llvm-commits mailing list