[PATCH] D143893: [CodeGenPrepare] Fix counting uses when folding addresses into memory instructions

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 19 23:23:26 PST 2023


mkazantsev added inline comments.


================
Comment at: llvm/test/CodeGen/Generic/addr-use-count.ll:1
+; RUN: llc --stop-after=codegenprepare < %s | FileCheck %s
+
----------------
Precommit test and use `utils/update_llc_test_checks.py` script to show what changed?


================
Comment at: llvm/test/CodeGen/Generic/addr-use-count.ll:270
+
+case19:
+    %t19 = getelementptr i32 *, ptr %addr, i32 1
----------------
Do we really need so many cases to demonstrate what's going on?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143893/new/

https://reviews.llvm.org/D143893



More information about the llvm-commits mailing list