[PATCH] D144282: [X86] Add tests for (or/and (icmp eq/ne A, C0), (icmp eq/ne A, C1)) where IsPow2(dif(C0, C1)); NFC

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 19 23:00:49 PST 2023


pengfei added a comment.

In D144282#4138035 <https://reviews.llvm.org/D144282#4138035>, @goldstein.w.n wrote:

> In D144282#4137911 <https://reviews.llvm.org/D144282#4137911>, @pengfei wrote:
>
>> Can we add tests on demand? It looks to me there are tests neither touched by D144283 <https://reviews.llvm.org/D144283> nor D144284 <https://reviews.llvm.org/D144284>.
>
> There are some intentionally not touched tests `*fail*`. Would you prefer I drop some of them?

Or otherwise adding comments to explain the intention.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144282/new/

https://reviews.llvm.org/D144282



More information about the llvm-commits mailing list