[PATCH] D144254: [llvm][Uniformity] a phi with an undef argument is not always divergent

[Ruiling, Song via Phabricator via llvm-commits]

ruiling accepted this revision.
ruiling added a comment.
This revision is now accepted and ready to land.

Although I wanted the optimization for the undef case to be bring back in a more defined way, I think it is acceptable to match with existing divergence analysis. This would help with the transition to uniform analysis, so LGTM. Please also address Jay's suggestion. Could you also add some FIXME around the code like: optimally reporting uniform with undef input should be done in more defined way. In general CFG, it might be broken?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144254/new/

https://reviews.llvm.org/D144254