[PATCH] D142705: [GVN] Support address translation through select instructions
Max Kazantsev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Feb 19 22:19:09 PST 2023
mkazantsev accepted this revision.
mkazantsev added a comment.
This revision is now accepted and ready to land.
All my objections seem resolved, thanks. I'm no expert in MemDep, so I don't know what implications come from introduction of new dependency type, so you might want to have someone else's opinion on this. Otherwise, LG.
================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:204
+ /// InsertPt - The position for select materialization.
+ Instruction *InsertPt;
----------------
init with nullptr?
================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:1136
+ auto [TrueAddr, FalseAddr] = SelectAddrs;
+ assert(TrueAddr && TrueAddr->getType() == Load->getPointerOperandType() &&
+ "Invalid address of true side of select dependency");
----------------
I'd just split them, to separate two issues (no addr and addr of wrong type).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142705/new/
https://reviews.llvm.org/D142705
More information about the llvm-commits
mailing list