[PATCH] D144343: [ConstantRange][SCEV] print unsigned ranges

Sat Feb 18 23:57:17 PST 2023

caojoshua added a comment.

In D144343#4137485 <https://reviews.llvm.org/D144343#4137485>, @nikic wrote:

> I'm okay with this, but just looking at the test diffs, I'm not sure how helpful this really is... I'd consider a range like `[0,-3)` to be easier to understand than `[0,18446744073709551613)`, even when interpreting it in an unsigned sense.

Yeah, I see what you mean now that I think about it again. I think its helpful for uint8, and maybe uint16, but beyond that the signed version is easier to read. We could add logic to print the unsigned version if its bitwidth is under some threshold, but it feels unnecessary.

I'll close this as won't fix.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144343/new/

https://reviews.llvm.org/D144343