[PATCH] D144333: [DivRemPairs] Strip division's poison generating flag

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/Scalar/DivRemPairs.cpp:376
+      // may replace a well-defined value 'X % Y' with poison.
+      if (DivInst->hasPoisonGeneratingFlags())
+        DivInst->dropPoisonGeneratingFlags();
----------------
Not really necessary to check has first.


================
Comment at: llvm/test/Transforms/DivRemPairs/AArch64/div-rem-pairs.ll:18
   ret i8 %5
 }
----------------
Please don't use unnamed instructions (`opt -S -passes=instnamer`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144333/new/

https://reviews.llvm.org/D144333