[PATCH] D142849: [ValueTracking] Add helper for handling `computeKnownBits` for and/xor/or; NFC
Noah Goldstein via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Feb 18 12:29:00 PST 2023
goldstein.w.n marked 3 inline comments as done.
goldstein.w.n added inline comments.
================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:1071
+
+ // We don't want to put this before the Known.One.isZero check.
+ switch (I->getOpcode()) {
----------------
nikic wrote:
> I don't understand this comment.
> I don't understand this comment.
Sorry, is outdated now that `KnownOut` is a seperate variable than `KnownLHS`. Removed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142849/new/
https://reviews.llvm.org/D142849
More information about the llvm-commits
mailing list