[PATCH] D144292: [SLP] Fix infinite loop in isUndefVector.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:379
+          return Res.reset();
         Base = II->getOperand(0);
         std::optional<unsigned> Idx = getInsertIndex(II);
----------------
ABataev wrote:
> Move `Base = II->getOperand(0);` before the if statement instead, it is not an error path
Updated, it looks like we are still missing test coverage for cases where it actually makes a difference though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144292/new/

https://reviews.llvm.org/D144292