[llvm] 4be1764 - [TextAPI] wrap returned Errors in std::move

Cyndy Ishida via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 17 16:18:13 PST 2023


Author: Cyndy Ishida
Date: 2023-02-17T16:16:12-08:00
New Revision: 4be17641b05df1e63fa8e069af92676f1246eb83

URL: https://github.com/llvm/llvm-project/commit/4be17641b05df1e63fa8e069af92676f1246eb83
DIFF: https://github.com/llvm/llvm-project/commit/4be17641b05df1e63fa8e069af92676f1246eb83.diff

LOG: [TextAPI] wrap returned Errors in std::move

Added: 
    

Modified: 
    llvm/lib/TextAPI/TextStubV5.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/TextAPI/TextStubV5.cpp b/llvm/lib/TextAPI/TextStubV5.cpp
index 431d285b3b2e5..30faad5531dda 100644
--- a/llvm/lib/TextAPI/TextStubV5.cpp
+++ b/llvm/lib/TextAPI/TextStubV5.cpp
@@ -404,12 +404,12 @@ Expected<TargetsToSymbols> getSymbolSection(const Object *File, TBDKey Key,
     if (DataSection) {
       auto Err = collectSymbolsFromSegment(DataSection, Result, SectionFlag);
       if (Err)
-        return Err;
+        return std::move(Err);
     }
     if (TextSection) {
       auto Err = collectSymbolsFromSegment(TextSection, Result, SectionFlag);
       if (Err)
-        return Err;
+        return std::move(Err);
     }
   }
 
@@ -442,7 +442,7 @@ Expected<AttrToTargets> getLibSection(const Object *File, TBDKey Key,
           Result[Key.str()] = MappedTargets;
         });
     if (Err)
-      return Err;
+      return std::move(Err);
   }
 
   return Result;
@@ -548,7 +548,7 @@ Expected<TBDFlags> getFlags(const Object *File) {
         });
 
     if (FlagsOrErr)
-      return FlagsOrErr;
+      return std::move(FlagsOrErr);
 
     return Flags;
   }


        


More information about the llvm-commits mailing list