[PATCH] D144302: [PGO] Setting ValueProfNode Array's Alignment

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfiling.h:30
 } __llvm_profile_data;
+static_assert(INSTR_PROF_DATA_ALIGNMENT >= _Alignof(__llvm_profile_data),
+    "INSTR_PROF_DATA_ALIGNMENT is too small.");
----------------
drop ending period. The format typically matches clang diagnostics which use no capitalization or trailing period.


================
Comment at: llvm/test/Instrumentation/InstrProfiling/alignment.ll:1
+; Tests that the globals inserted all have the correct alignments specified.
+; RUN: opt %s -mtriple=powerpc64-unknown-linux -passes=instrprof -S | FileCheck %s
----------------
It's not necessary to add a new test. Just find an existing one and more CHECK lines there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144302/new/

https://reviews.llvm.org/D144302