[PATCH] D45508: Implement --ctors-in-init-array.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay commandeered this revision.
MaskRay edited reviewers, added: ruiu; removed: MaskRay.
MaskRay added a comment.

In D45508#4135578 <https://reviews.llvm.org/D45508#4135578>, @skirkovski wrote:

> Hey folks,
>
> Is this patch still relevant to the upstream community ?

No, it is increasingly unnecessary, see https://maskray.me/blog/2021-11-07-init-ctors-init-array , especially the chapter ".ctors to .init_array transition".

> GCC12 is starting to be deployed more and more in production and this kind of issues are at scale for all kinds of companies, so there is interest to get this landed or to find a workaround that does not include rebuilding everything.
>
> LD' s inker script has for years put all .{c,d]tors in .{init,fini}_array. Do you see any issue in implementing the same for lld ?

I think you misunderstand things. GCC 4.7 switched from .ctors to .init_array . At the current GCC 12 time .ctors is very obsoleted now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D45508/new/

https://reviews.llvm.org/D45508