[PATCH] D144276: [ORC] Introduce SetUpExecutorNativePlatform utility.

[Sunho Kim via Phabricator via llvm-commits]

sunho added inline comments.


================
Comment at: llvm/include/llvm/ExecutionEngine/Orc/LLJIT.h:456
+/// native target for the executor.
+class SetUpExecutorNativePlatform {
+public:
----------------
Something worth adding to this interface for COFF side of view is add constructor that receive vcruntime path. Without manually shipping them program will not run for people that do not have vc toolchain installed in their computer. Even better instead of path receive memorybuffer so that ORC users can embed vcruntime libs.

Maybe this class is not right place to add though as its supposed to be generic it seems but we do have this kind of use case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144276/new/

https://reviews.llvm.org/D144276