[PATCH] D144270: [LTO/WPD] Allow devirtualization to function alias in vtable

Mingming Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 17 11:16:43 PST 2023


mingmingl accepted this revision.
mingmingl added a comment.
This revision is now accepted and ready to land.

The change to handle function alias for single-impl-devirt LGTM. The current way of bailing-out-upon-function-alias where function is assumed (e.g., virtual const propagation) sounds reasonable (since function-aliases are not handled correctly).

Maybe wait a little bit more for people with more experience in other optimizations that need to analyze function content to chime in; if no concerns we can land this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144270/new/

https://reviews.llvm.org/D144270



More information about the llvm-commits mailing list