[PATCH] D141940: [SLP]Add shuffling of extractelements to avoid extra costs/data movement.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

A couple of minors



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:6852
+    bool Resized = false;
+    if (VecBase)
+      if (auto *VecBaseTy = dyn_cast<FixedVectorType>(VecBase->getType()))
----------------
if (Value *VecBase = AdjustExtractsCost(Cost, ExtractMask)) ?


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:9403
+    bool Resized = false;
+    if (VecBase)
+      if (auto *VecBaseTy = dyn_cast<FixedVectorType>(VecBase->getType()))
----------------
if (Value *VecBase = AdjustExtracts(E, ExtractMask)) ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141940/new/

https://reviews.llvm.org/D141940