[PATCH] D143508: [ELF][llvm-objcopy] Reject duplicate SHT_SYMTAB sections.

Moshe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 17 07:39:04 PST 2023


MosheBerman added a comment.

In D143508#4134286 <https://reviews.llvm.org/D143508#4134286>, @jhenderson wrote:

> In D143508#4129850 <https://reviews.llvm.org/D143508#4129850>, @MosheBerman wrote:
>
>> In D143508#4129491 <https://reviews.llvm.org/D143508#4129491>, @jhenderson wrote:
>>
>>> Code LGTM. Could you reformat the description so that it matches your planned commit message, please?
>>
>> Great! I'll update the description.
>>
>>> Do you have commit access?
>>
>> I do not. This is my first diff, so I think I'm supposed to have a committer land it for me. I'll follow your lead.
>
> Okay, please let me know your name and email address that should be listed in the commit message.

My name is Moshe Berman, and my email is mosheberman at users.noreply.github.com.

> FYI, there's a typo in your commit message ("craashing"). I'll fix that when landing this, unless you get there first.

I attempted to fix it just now. Feel free to tweak the commit message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143508/new/

https://reviews.llvm.org/D143508



More information about the llvm-commits mailing list