[PATCH] D144005: [DwarfDebug] Move emission of types from beginModule() to endModule() (4/7)

[Kristina Bessonova via Phabricator via llvm-commits]

krisb created this revision.
Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, kerbowa, hiraditya, jvesely.
Herald added a project: All.
krisb edited the summary of this revision.
krisb added reviewers: dblaikie, jmmartinez.
krisb added projects: LLVM, debug-info.
krisb published this revision for review.
Herald added subscribers: llvm-commits, jholewinski.

RFC https://discourse.llvm.org/t/rfc-dwarfdebug-fix-and-improve-handling-imported-entities-types-and-static-local-in-subprogram-and-lexical-block-scopes/68544

This patch proposes to move the emission of types and type-like entities from
`DwarfDebug::beginModule()` to `DwarfDebug::endModule()`. Effectively, this changes
nothing but the order of debug entities in the resulting DWARF.

This is needed to simplify DWARF emission in a context of proper support of
function-local types which comes in the next patch (D144006 <https://reviews.llvm.org/D144006>), making all
the types handled in a single place, together with other global and
local entities.

No functional changes intended.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D144005

Files:
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  llvm/test/CodeGen/AMDGPU/dwarf-multi-register-use-crash.ll
  llvm/test/DebugInfo/Generic/debug-info-qualifiers.ll
  llvm/test/DebugInfo/Generic/enum-types.ll
  llvm/test/DebugInfo/Generic/incorrect-variable-debugloc.ll
  llvm/test/DebugInfo/Generic/namespace.ll
  llvm/test/DebugInfo/Generic/varargs.ll
  llvm/test/DebugInfo/MIR/AArch64/implicit-def-dead-scope.mir
  llvm/test/DebugInfo/NVPTX/debug-loc-offset.ll
  llvm/test/DebugInfo/X86/align_cpp11.ll
  llvm/test/DebugInfo/X86/debug-info-blocks.ll
  llvm/test/DebugInfo/X86/gnu-public-names.ll
  llvm/test/DebugInfo/X86/sret.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144005.497298.patch
Type: text/x-patch
Size: 17116 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230217/cb1eabe0/attachment.bin>