[PATCH] D144260: [mlir][linalg][TransformOps] Connect hoistRedundantVectorTransfers

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache accepted this revision.
nicolasvasilache added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td:1727
+
+    The operation always returns the handle to the transformed function op.
+  }];
----------------
`always succeeds and returns a handle to` ?


================
Comment at: mlir/test/Dialect/Linalg/transform-op-hoisting.mlir:1
+// RUN: mlir-opt  -test-transform-dialect-interpreter --split-input-file --allow-unregistered-dialect %s | FileCheck %s
+
----------------
This looks similar to what I remember adding in the past.
Can we take the opportunity to also delete the old test pass and just update the test command-line ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144260/new/

https://reviews.llvm.org/D144260