[PATCH] D143857: [X86] Add tests for shuffle as shift/rotate; NFC

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with a few minors



================
Comment at: llvm/test/CodeGen/X86/shuffle-as-shifts.ll:3
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mcpu=skylake-avx512  | FileCheck %s --check-prefixes=CHECK-SKX
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mcpu=icelake-server  | FileCheck %s --check-prefixes=CHECK-ICX
+
----------------
Include a test run with x86-86-v4 (and maybe znver4)


================
Comment at: llvm/test/CodeGen/X86/shuffle-as-shifts.ll:6
+
+define <4 x i32> @shuf_rot_v4i32(<4 x i32> %x) {
+; CHECK-SKX-LABEL: shuf_rot_v4i32:
----------------
Maybe rename these to include the shuffle mask - its often very useful when searching: shuffle_rot_v4i32_1032 etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143857/new/

https://reviews.llvm.org/D143857