[PATCH] D144108: [mlir][LinAlg][Transform] Add a transform op for conv2d to im2col

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp:3044
+    transform::TransformState &state) {
+  IRRewriter rewriter(target->getContext());
+  rewriter.setInsertionPoint(target);
----------------
Note: @ftynse @nicolasvasilache, unless I missed it, there's no way to report the `notifyMatchFailure` in the transform dialect, right now.
I think it would be interesting to have our own specialization of the `IRRewriter` to log these errors as part of the errors we report with emitSilenceableError and so on.

What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144108/new/

https://reviews.llvm.org/D144108